Grafi 56/improve async call and integration tests #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the async workflow execution through better quiescence detection and refactors integration test infrastructure for improved reporting and maintainability.
Key changes:
- Enhanced
AsyncNodeTrackerwith message-level tracking for accurate quiescence detection - Simplified
AsyncOutputQueuetermination logic by delegating quiescence checks to the tracker - Refactored integration test runners to support programmatic execution with structured result reporting
Reviewed changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
pyproject.toml, uv.lock |
Version bump from 0.0.33 to 0.0.34 |
grafi/workflows/impl/async_node_tracker.py |
Major refactor adding message tracking (published/committed) for accurate quiescence detection; added force stop capability |
grafi/workflows/impl/async_output_queue.py |
Simplified termination logic by delegating quiescence detection to tracker; improved listener implementation |
grafi/workflows/impl/event_driven_workflow.py |
Integrated message tracking into workflow orchestration; added force stop support |
grafi/workflows/impl/utils.py |
Added optional tracker parameter to publish_events for message tracking |
tests_integration/run_all.py |
Refactored to load runners as modules instead of subprocess calls; improved result reporting |
tests_integration/*/run_*.py (12 files) |
Added collect parameter for programmatic execution; improved stdout encoding handling; structured result format |
tests/workflow/test_async_node_tracker.py |
Updated tests for new quiescence detection model |
tests/workflow/test_async_output_queue.py |
Comprehensive new tests for race condition fixes and quiescence behavior |
tests/assistants/test_assistant.py |
Added 8-node DAG workflow test validating complex fan-out/fan-in patterns |
tests_integration/hith_assistant/kyc_assistant_example.py |
Fixed to pass consumed_event_ids for proper event chaining |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ayomaska18
approved these changes
Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1: improved async call, safer and more stable
2: improve integration tests